-
Notifications
You must be signed in to change notification settings - Fork 9
Pheemy Lathe #86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pheemy Lathe #86
Conversation
shut up copilot oml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like a major idea when we were discussing this stuff in discord was that the lathe was kinda a singular hulking machine with interesting properties as a result. You can't move it, it's physically large, and it can hurt you just by being near it when it's running. I feel like those ideas should be included and elaborated on in this doc.
In general, i like the concept and the basics are here, but it just needs more specifics on how it works and why those decisions have positive effects on the game.
|
I think I definitely forgot to metnion a few things (namely the size) because they were just so ingrained into my brain image I didn't remember they weren't implied. |
|
Just pushing this as it is so it can be reviewed while I sleep. focused mostly on rust for this one. |
EmoGarbage404
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good improvement. Most of the stuff at the core is solid just needs a bit more elaboration + simplification imo
|
This commit is missing some finishing touches and some of the crew interaciton stuff, but I'm pretty comfortable with how it is now. |
|
Uh also there's the whole thing of the lathe breaking the laws of conservation by producing infinite water vapour but idk how to solve that without introducing coolant which would be a little too much imo? up for it if that's what's desired though |
|
i have no problem with it doing that |
EmoGarbage404
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
final nitpicks and cleanup
file also needs to be added to SUMMARY.md
Co-authored-by: Nemanja <98561806+EmoGarbage404@users.noreply.github.com>
|
happy with this in its current state |
I've not written a doc before so expect bad
Suggest/ force modifications at will